Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Test with Poplar 3.3 #45

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[CI] Test with Poplar 3.3 #45

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35f9f0f
[CI] Test with Poplar 3.3
giordano Mar 14, 2024
9e0f002
[CI] Explicitly export environment variables
giordano Apr 9, 2024
dd818fd
Only run with Poplar v3.3.0 for the time being, for testing
giordano Apr 9, 2024
9f03bd1
[CI] Only declare git repo safe when building docs
giordano Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,15 @@ jobs:
fail-fast: false
matrix:
include:
- julia_version: "1.9"
docker_image: graphcore/poplar:2.5.1-ubuntu-20.04-20220629
# - julia_version: "1.9"
# docker_image: graphcore/poplar:2.5.1-ubuntu-20.04-20220629
# build_docs: false
# - julia_version: "1.10"
# docker_image: graphcore/poplar:3.2.0-ubuntu-20.04-20230314
# build_docs: true
- julia_version: "^1.11.0-0"
docker_image: graphcore/poplar:3.3.0-ubuntu-20.04-20230703
build_docs: false
- julia_version: "1.10"
docker_image: graphcore/poplar:3.2.0-ubuntu-20.04-20230314
build_docs: true
steps:
- name: "Install, g++, git, jq"
# g++ is needed to build the wrapper, git to publish the docs, jq for
Expand All @@ -35,6 +38,7 @@ jobs:
DEBIAN_FRONTEND: noninteractive
- uses: actions/checkout@v4
- name: "Declare git repo safe"
if: ${{ matrix.build_docs }}
# In the docker container the repo is owned by 1001:123, causing the
# following error when running git commands:
#
Expand All @@ -54,6 +58,19 @@ jobs:
cache-artifacts: "true"
cache-packages: "true"
cache-compiled: "true"
- name: "Export environment variables"
# Starting from graphcore/poplar:3.3.0 some environment variables like `CPATH` and
# `LD_LIBRARY_PATH`, which we need for building the bindings, are only set with the
# `bash` shell, while GHA uses by default `sh` for steps inside containers. So we
# need to start a step with `shell: bash` and re-export the relevant variables for
# the following steps.
shell: bash
run: |
echo "PATH=${PATH}" >> "${GITHUB_ENV}"
echo "CPATH=${CPATH}" >> "${GITHUB_ENV}"
echo "LIBRARY_PATH=${LIBRARY_PATH}" >> "${GITHUB_ENV}"
echo "LD_LIBRARY_PATH=${LD_LIBRARY_PATH}" >> "${GITHUB_ENV}"
echo "POPLAR_SDK_ENABLED=${POPLAR_SDK_ENABLED}" >> "${GITHUB_ENV}"
- uses: julia-actions/julia-buildpkg@v1
env:
CXX: g++
Expand Down
Loading