-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add RGB -> monochrome read test #315
Conversation
3d45928
to
9b8ecc2
Compare
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
==========================================
+ Coverage 81.45% 82.90% +1.44%
==========================================
Files 17 17
Lines 1181 1503 +322
==========================================
+ Hits 962 1246 +284
- Misses 219 257 +38
Continue to review full report at Codecov.
|
3963ae2
to
e9fcac4
Compare
Thanks for adding this much needed test. If you have the bandwidth, I think it would make sense to test for accuracy, as well as making sure it does not error. |
Unfortunately this still doesn't hit the problematic code path. We need a test that hits Line 311 in 33200c2
|
Tests the failure in #313 (this should fail on master)
Should be merged with the correct failure before #314