Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RGB -> monochrome read test #315

Merged
merged 6 commits into from
Mar 6, 2022
Merged

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Apr 7, 2021

Tests the failure in #313 (this should fail on master)

Should be merged with the correct failure before #314

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #315 (dc902b2) into master (33200c2) will increase coverage by 1.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
+ Coverage   81.45%   82.90%   +1.44%     
==========================================
  Files          17       17              
  Lines        1181     1503     +322     
==========================================
+ Hits          962     1246     +284     
- Misses        219      257      +38     
Impacted Files Coverage Δ
src/avio.jl 84.91% <100.00%> (+3.57%) ⬆️
src/util.jl 91.30% <0.00%> (-3.44%) ⬇️
src/testvideos.jl 73.80% <0.00%> (-3.12%) ⬇️
src/avframe_transfer.jl 81.69% <0.00%> (-1.73%) ⬇️
src/avdictionary.jl 8.82% <0.00%> (-0.56%) ⬇️
src/info.jl 100.00% <0.00%> (ø)
src/frame_graph.jl 99.23% <0.00%> (+0.05%) ⬆️
src/encoding.jl 94.73% <0.00%> (+1.53%) ⬆️
src/avptr.jl 69.09% <0.00%> (+2.42%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33200c2...dc902b2. Read the comment docs.

@galenlynch
Copy link
Collaborator

Thanks for adding this much needed test. If you have the bandwidth, I think it would make sense to test for accuracy, as well as making sure it does not error.

@IanButterworth
Copy link
Member Author

Unfortunately this still doesn't hit the problematic code path. We need a test that hits

frame_graph.src_depth = frame_graph.dst_depth = bits_per_pixel

@IanButterworth IanButterworth reopened this Mar 6, 2022
@IanButterworth IanButterworth merged commit dfd9d32 into master Mar 6, 2022
@giordano giordano deleted the IB/add_rgb_mono_test branch March 17, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants