-
Notifications
You must be signed in to change notification settings - Fork 19
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix bugs handling unusual tarballs with directory after contents (#105)
This fixes three related bugs when processing tarballs where a directory entry appears *after* some contents of that directory. This is unusual since neither command-line `tar` nor `Tar.create` will produce tarballs like this, and I only dicovered the bug when I accidentally modified `Tar.create` to emit directory entries after emiting everything inside of the directory. Each of `extract`, `tree_hash` and `rewrite` did this wrong in slightly different ways previously. Now they all (hopefully) do the right thing, and we test that they each handle a manually generated tarball with this kind of unusual ordering. (cherry picked from commit 9316af8)
- Loading branch information
1 parent
2972f5e
commit 0906dfa
Showing
3 changed files
with
42 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters