Update Clang.jl generator scripts #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passes tests, but at least `png_imagep` is incorrect. See JuliaInterop/Clang.jl#326
There was a problem hiding this comment.
@melonedo I just noticed that CI wasn't enabled for PRs, thus I updated our CI configurations in #37, can you run
git remote add upstream https://github.com/JuliaIO/PNGFiles.jl.git
git pull upstream master --rebase
git push origin master -fto update the CI configuration so that we can test this PR?
Edit: Okay no need to do so, since the close&reopen trick works.
|
Let me see if close&reopen triggers our CI |
|
Seems the tests failure are due to #22, that patch has been applied. |
Gnimuc
reviewed
Sep 2, 2021
| const PNG_BYTES_TO_CHECK = 8 | ||
| const tm = Libc.TmStruct | ||
| const time_t = UInt | ||
| const jmp_buf = Nothing |
There was a problem hiding this comment.
If jmp_buf is only used as an opaque pointer in the library, this is OK. Otherwise, it should be carefully defined for different platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade generator scripts because the old one will become end-of-support soon.
Tests are passed and most changes seem harmless. The changes are extracted at https://gist.github.com/melonedo/eefdbd1f4573c3a17ff2cddbeb1dce7f/revisions.
cc @Gnimuc