Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XSD Schema validation #111

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Add XSD Schema validation #111

wants to merge 23 commits into from

Conversation

wherrera10
Copy link

add the libxml2's functionality to validate XML against an XSD schema.

@musm musm requested a review from omus September 21, 2020 16:43
Copy link
Member

@omus omus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks reasonable

README.md Show resolved Hide resolved
src/schema.jl Outdated Show resolved Hide resolved
src/schema.jl Outdated Show resolved Hide resolved
src/schema.jl Show resolved Hide resolved
src/schema.jl Outdated Show resolved Hide resolved
src/schema.jl Outdated Show resolved Hide resolved
test/validate.jl Show resolved Hide resolved
src/schema.jl Outdated Show resolved Hide resolved
Copy link
Member

@omus omus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to be able to retrieve why validation failed but this seems a step in the right direction at least

test/validate.jl Show resolved Hide resolved
@wherrera10
Copy link
Author

The current version works correctly under Linux. Libxml2 behavior with the xml file, xsd file function seemed different between Linux and Windows (Linux seemed to expect the schema and xml files to contain a root value referring to a common namespace and the Windows version did not), so the current version does not use that libxml function, which simplifies the code buy several lines anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants