Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add find_element and get_elements_by_tagname methods #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vargonis
Copy link

  1. It is proposed that find_element and get_elements_by_tagname accept, besides an XMLElement, also an XMLDocument as first argument.
  2. A method find_element(x, ns::Vector{<:AbstractString}) is implemented. It just folds find_element over the vector of abstract strings.

@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #105 into master will decrease coverage by 2.45%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage   76.97%   74.52%   -2.46%     
==========================================
  Files           6        6              
  Lines         152      157       +5     
==========================================
  Hits          117      117              
- Misses         35       40       +5
Impacted Files Coverage Δ
src/nodes.jl 78.84% <0%> (-0.77%) ⬇️
src/document.jl 75% <0%> (-9.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a5e3a6...ef29d7f. Read the comment docs.

@omus
Copy link
Member

omus commented Feb 24, 2020

Needs tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants