-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for range of the spherical angle #22
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
=======================================
Coverage 93.91% 93.91%
=======================================
Files 4 4
Lines 148 148
=======================================
Hits 139 139
Misses 9 9 ☔ View full report in Codecov by Sentry. |
I think the current implementation does what you need because the two-argument With this, I would like to stay with the current implementation, because it is slightly faster than the usage of |
I see what you mean for the range, it's likely correct. I'd add a test for it. |
Confirm that the range is what I want: I've added the test for the ranges. |
Closes #20
Checklist