Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: json form fields and node counting #107

Merged
merged 26 commits into from
Jun 17, 2024
Merged

fix: json form fields and node counting #107

merged 26 commits into from
Jun 17, 2024

Conversation

ianna
Copy link
Member

@ianna ianna commented Jun 17, 2024

The node counting made the same as in the arrays created from uproot: the node0 is the top RecordArray layout.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.93%. Comparing base (96c45c4) to head (9a26c4e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   76.91%   76.93%   +0.01%     
==========================================
  Files           5        5              
  Lines        1798     1799       +1     
==========================================
+ Hits         1383     1384       +1     
  Misses        415      415              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ianna ianna merged commit 29b8620 into main Jun 17, 2024
9 checks passed
@ianna ianna deleted the ianna/fix_json_form branch June 17, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant