Allow setting a background color for a gplot (included in PR #186) #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-distinguish args, kwargs -add missing kwargs
clarify that Cairo is required to visualize in vscode
Checking for System OS was outdated
Now matches gadfly.jl (https://github.com/GiovineItalia/Gadfly.jl/blob/master/src/open_file.jl)
-allow gplothtml to accept same arguments as gplot -allow x/y-locs to be of different type (<: Real)
and minor changes to plots.jl update README
hdavid16
changed the title
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
=======================================
Coverage 32.92% 32.92%
=======================================
Files 9 9
Lines 565 565
=======================================
Hits 186 186
Misses 379 379
Help us with your feedback. Take ten seconds to tell us how you rate us. |
README.md
Outdated
| @@ -183,6 +183,7 @@ gplot(h) | |||
| + `arrowangleoffset` Angular width in radians for the arrows. Default: `π/9 (20 degrees)` | |||
| + `linetype` Type of line used for edges ("straight", "curve"). Default: "straight" | |||
| + `outangle` Angular width in radians for the edges (only used if `linetype = "curve`). Default: `π/5 (36 degrees)` | |||
| + `backgroundc` Color for the plot background. Default: `nothing` | |||
There was a problem hiding this comment.
I know that for other params we alse use the c postfix, but maybe we should just call it background_color.
There was a problem hiding this comment.
yes! Should we think about changing the kwargs to being more verbose? nodefill_color, etc.
|
Would it be possible to add a test for the background color option? |
I just added a fourth test in the karate test, where the background color is set to lightyellow |
Merged
hdavid16
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #172