Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NeighborLoader #497

Merged
merged 33 commits into from
Nov 3, 2024
Merged

feat: add NeighborLoader #497

merged 33 commits into from
Nov 3, 2024

Conversation

askorupka
Copy link
Collaborator

This PR adds NeighborLoader functionality for big graphs.
This is similar to https://pytorch-geometric.readthedocs.io/en/latest/tutorial/neighbor_loader.html

PR with documentation will follow.

@askorupka
Copy link
Collaborator Author

Hi @CarloLucibello I just wanted to check if it's ok to add Graphs to deps instead of weakdeps, or do you see any better solutions instead.
I need it to use Graphs.neighbors function in graph subsampling.

GraphNeuralNetworks/src/samplers.jl Outdated Show resolved Hide resolved
GraphNeuralNetworks/src/samplers.jl Outdated Show resolved Hide resolved
GraphNeuralNetworks/src/samplers.jl Outdated Show resolved Hide resolved
GraphNeuralNetworks/src/samplers.jl Outdated Show resolved Hide resolved
GraphNeuralNetworks/src/samplers.jl Outdated Show resolved Hide resolved
GraphNeuralNetworks/src/samplers.jl Outdated Show resolved Hide resolved
src/samplers.jl Outdated Show resolved Hide resolved
@CarloLucibello
Copy link
Member

Hi @CarloLucibello I just wanted to check if it's ok to add Graphs to deps instead of weakdeps, or do you see any better solutions instead.
I need it to use Graphs.neighbors function in graph subsampling.

It is fine, Graphs.jl is already a dependence through GNNGraphs.jl

@askorupka
Copy link
Collaborator Author

Now dependent on & blocked by #499

@askorupka askorupka force-pushed the feat/neighbor_loader branch from 4d1e9be to 5e7544c Compare October 12, 2024 11:58
GraphNeuralNetworks/src/samplers.jl Outdated Show resolved Hide resolved
GraphNeuralNetworks/src/samplers.jl Outdated Show resolved Hide resolved
GraphNeuralNetworks/src/samplers.jl Outdated Show resolved Hide resolved
GraphNeuralNetworks/src/samplers.jl Outdated Show resolved Hide resolved
GraphNeuralNetworks/src/samplers.jl Outdated Show resolved Hide resolved
GraphNeuralNetworks/src/samplers.jl Show resolved Hide resolved
@askorupka
Copy link
Collaborator Author

@CarloLucibello ready for another look

Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
GraphNeuralNetworks/src/samplers.jl Outdated Show resolved Hide resolved
GraphNeuralNetworks/src/samplers.jl Outdated Show resolved Hide resolved
GraphNeuralNetworks/src/samplers.jl Outdated Show resolved Hide resolved
GraphNeuralNetworks/src/samplers.jl Outdated Show resolved Hide resolved
@CarloLucibello CarloLucibello merged commit 6b8a7fb into master Nov 3, 2024
5 checks passed
@CarloLucibello CarloLucibello deleted the feat/neighbor_loader branch November 12, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants