Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traffic prediction tutorial #324

Merged

Conversation

aurorarossi
Copy link
Member

A tutorial explaining this example

@CarloLucibello
Copy link
Member

Looks good. Did you generate the docs with julia 1.9.1, as prescribed by
https://carlolucibello.github.io/GraphNeuralNetworks.jl/dev/dev/#Caching-tutorials
?

Flux.mae(ŷ, y)
end
Flux.update!(opt, model, grads[1])
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still the indentation is wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my editor and documentation it shows correctly, I changed the github setting to tab size 4 and I can see it right here as well.

@aurorarossi
Copy link
Member Author

Looks good. Did you generate the docs with julia 1.9.1, as prescribed by https://carlolucibello.github.io/GraphNeuralNetworks.jl/dev/dev/#Caching-tutorials ?

yes

@CarloLucibello CarloLucibello merged commit 9a5d726 into JuliaGraphs:master Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants