Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove precompile info to prevent precompile warning #264

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Remove precompile info to prevent precompile warning #264

merged 1 commit into from
Jun 5, 2023

Conversation

jaakkor2
Copy link
Contributor

@jaakkor2 jaakkor2 commented Jun 5, 2023

With Luxor v3.7.0 I see

(@v1.9) pkg> precompile
Precompiling project...
  165 dependencies successfully precompiled in 481 seconds. 304 already precompiled.
  1 dependency had warnings during precompilation:
┌ Luxor [ae8d54c2-7ccd-5906-9d76-62fc9837b5bc]
│  [ Info: SnoopPrecompile is analyzing Luxor.jl code...
└

Note: SnoopPrecompile has been miograted to PrecompileTools in #263 , but there has not been a release.

I suggest removing the line

@info "PrecompileTools is analyzing Luxor.jl code..."

from https://github.com/JuliaGraphics/Luxor.jl/blob/master/src/precompile.jl

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (375bb99) 74.66% compared to head (53b2809) 74.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   74.66%   74.67%           
=======================================
  Files          33       33           
  Lines        6541     6542    +1     
=======================================
+ Hits         4884     4885    +1     
  Misses       1657     1657           
Impacted Files Coverage Δ
src/precompile.jl 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cormullion cormullion merged commit 261f2d2 into JuliaGraphics:master Jun 5, 2023
@cormullion
Copy link
Member

Thanks!

@jaakkor2 jaakkor2 deleted the patch-1 branch June 5, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants