Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Add GdkRGBA, ColorChooserDialog, ColorButton #533

Merged
merged 3 commits into from
Nov 24, 2020

Conversation

coloursofnoise
Copy link
Contributor

Relevant Gtk docs: GdkRGBA, GtkColorChooserDialog, GtkColorButton.

Partially replaces #244 (and by extension partially closes #243).

Also adds color_chooser_dialog convenience function for displaying a GtkColorChooserDialog similarly to open_dialog/save_dialog.
color_chooser_dialog returns nothing if no color is selected (cancel or close button pressed) to distinguish from just selecting the default color.

GtkColorChooserDialog is still subject to #530, so it may be worth also adding the deprecated GtkColorSelectionDialog, which seems to work just fine.

I also took a look at the generator scripts; the Clang ones are outdated for the latest version of Clang.jl, and I was unable to successfully downgrade the package to test their recommendation for Backwards Compatibility.

@tknopp
Copy link
Collaborator

tknopp commented Nov 23, 2020

great! Could you add tests?

@tknopp tknopp merged commit 7c8802a into JuliaGraphics:master Nov 24, 2020
@tknopp
Copy link
Collaborator

tknopp commented Nov 24, 2020

great, thanks!

@tknopp
Copy link
Collaborator

tknopp commented Nov 24, 2020

So, if the generator scripts are a different point. It would be really great if they would work again. So if you want to work on this, it would be great.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting setproperty! on GtkTextTag for foreground_rgba to work
2 participants