Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

RCF: better shortcut facilities #310

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jonathanBieler
Copy link
Collaborator

This solves a couple of issues:

  • It makes it a bit easier to create keyboard shortcuts and to check them against events.
  • It checks correctly shortcuts, taking into account CapsLock and such.
  • It introduce platform dependent Modifiers (PrimaryModifier and SecondaryModifer) so you can have consistent shortcuts between windows/linux and OS X (PrimaryModifier refers to Control on windows and Command on OS X).
  • It checks correctly (I think) the Command key on OS X (which is also the Meta key by default).

@yakir12
Copy link
Contributor

yakir12 commented Mar 1, 2018

Too bad this hasn't been merged yet, I sure could use this now...

@tknopp
Copy link
Collaborator

tknopp commented Mar 1, 2018

@yakir12 would you like to get commit access so that you can merge yourself? There are currently 0 maintainer, thats the issue.

@yakir12
Copy link
Contributor

yakir12 commented Mar 1, 2018

@tknopp, PM you on Discourse.

@tknopp
Copy link
Collaborator

tknopp commented Jun 2, 2018

@jonathanBieler: should this be merged?

@jonathanBieler
Copy link
Collaborator Author

I think it would be nice yes. That said I'm not super convinced by doing(Shortcut, event) (I had an Action type before that made more sense with doing) but I can't think of a better name right now (isshortcut isn't nice).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants