-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize colormap
#509
Merged
Merged
Optimize colormap
#509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
==========================================
- Coverage 94.07% 94.01% -0.06%
==========================================
Files 9 9
Lines 1249 1270 +21
==========================================
+ Hits 1175 1194 +19
- Misses 74 76 +2
Continue to review full report at Codecov.
|
kimikage
force-pushed
the
optimize_colormap
branch
3 times, most recently
from
August 3, 2021 09:58
204a31b
to
ceda821
Compare
johnnychen94
reviewed
Aug 3, 2021
kimikage
force-pushed
the
optimize_colormap
branch
from
August 6, 2021 04:05
af99a4c
to
7999272
Compare
kimikage
force-pushed
the
optimize_colormap
branch
from
August 15, 2021 03:32
7999272
to
229adf2
Compare
kimikage
force-pushed
the
optimize_colormap
branch
from
August 30, 2021 14:56
229adf2
to
32a2ed1
Compare
Remaining problems:
These can be tackled in separate PRs, though. |
kimikage
force-pushed
the
optimize_colormap
branch
2 times, most recently
from
September 9, 2021 07:58
3be629f
to
ba49c53
Compare
This uses `Tuple` instead of `Vector` for the colormap parameters. This also unifies the type of preset values to `Float64`.
kimikage
force-pushed
the
optimize_colormap
branch
from
September 20, 2021 03:40
ba49c53
to
2466f17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
Tuple
instead ofVector
for thecolormap
parameters. (cf. ddfe8d5)This also unifies the type of preset values to
Float64
.However, at present, there is no speed improvement. 😭
I will make some more tweaks and add some tests.
This is more of a compilation time issue than a runtime performance issue. I am guessing that there is some relation between the precompilation problem with
colormap
and #496.before
after (w/o PR #511)
after (w/ PR #511)
This also fixes the problem with hue interpolation.