Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the accessor vertices to the API. #76

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

tpapp
Copy link
Contributor

@tpapp tpapp commented Mar 27, 2024

This allows the user to access this field of Curve2D objects directly, without allocations.

  • add a basic test
  • add to docs
  • incidental change: add compat for testing packages (otherwise Aqua complains on Julia 1.10)
  • incidental change: add 1 and remove nightly from CI

tpapp added 3 commits March 27, 2024 10:46
This allows the user to access this field of `Curve2D` objects
directly, without allocations.

- add a basic test
- add to docs
- indcidental change: add compat for testing packages (otherwise Aqua
  complains on Julia 1.10)
(testing on nightly is not recommended)
@tpapp
Copy link
Contributor Author

tpapp commented Apr 2, 2024

Friendly ping: @sjkelly, I wonder if you could consider reviewing this trivial PR.

@sjkelly
Copy link
Member

sjkelly commented Apr 2, 2024

Thanks for the reminder!

@sjkelly sjkelly merged commit 8b21f57 into JuliaGeometry:master Apr 2, 2024
5 checks passed
@tpapp tpapp deleted the tp/add-vertices branch April 3, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants