Implement performance improvements using bit masking #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…culation The chief suspect in allocation (and triggering GC) was all the small arrays allocated to handle ambiguous cases. With this solution we use the 5th bit (0x10) to indicate an ambiguous case. The logic to disambiguate is handled in the processing of crossings. This significantly reduces memory allocations and yields modest performance improvements.
Closed
SimonDanisch
approved these changes
Feb 14, 2020
|
@SimonDanisch @tomasaschan I have tested this with the MakieGallery regression suite and all looks good. I plan to merge later this week if there are no objections. |
SimonDanisch
approved these changes
Mar 3, 2020
sjkelly
added a commit
that referenced
this pull request
Mar 4, 2020
sjkelly
added a commit
that referenced
this pull request
Mar 10, 2020
cleanup some of the logic from #50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chief suspect in allocation (and triggering GC) was all the small arrays allocated
to handle ambiguous cases. With this solution we use the 5th bit (0x10) to indicate
an ambiguous case. The logic to disambiguate is handled in the processing of crossings.
This significantly reduces memory allocations and yields modest performance improvements.
This is a cleaned up version of #49 without the hashing hacks.
Memory: 2.22Mb -> 985Kb
Allocations: 21,188 -> 1,189
Net performance gain: ~25%