Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for KernelAbstraction 0.9 #300

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Add support for KernelAbstraction 0.9 #300

merged 2 commits into from
Apr 5, 2023

Conversation

vchuravy
Copy link
Member

No description provided.

@maleadt
Copy link
Member

maleadt commented Apr 5, 2023

i128 failure was a typo in the skip list. 1.6 issues remain, and are different.

julia> using oneAPI, oneAPI.oneAPIKernels, KernelAbstractions

julia> backend = oneAPIBackend()
oneAPIBackend()

julia> @kernel function index_linear_global(A)
              I = @index(Global, Linear)
              A[I] = I
       end
index_linear_global (generic function with 4 methods)

julia> A = allocate(backend, Int, 16, 16)
16×16 oneMatrix{Int64, oneAPI.oneL0.DeviceBuffer}:
 0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0
 0  0  0  0  0  0  0  0  0  0  0  0  0  0  0  0

julia> index_linear_global(backend, 8)(A, ndrange=length(A))
ERROR: GPU compilation of MethodInstance for gpu_index_linear_global(::KernelAbstractions.CompilerMetadata{KernelAbstractions.NDIteration.DynamicSize, KernelAbstractions.NDIteration.DynamicCheck, Nothing, CartesianIndices{1, Tuple{Base.OneTo{Int64}}}, KernelAbstractions.NDIteration.NDRange{1, KernelAbstractions.NDIteration.DynamicSize, KernelAbstractions.NDIteration.StaticSize{(8,)}, CartesianIndices{1, Tuple{Base.OneTo{Int64}}}, Nothing}}, ::oneDeviceMatrix{Int64, 1}) failed
KernelError: kernel returns a value of type `Union{}`

@maleadt
Copy link
Member

maleadt commented Apr 5, 2023

Hmm, it's simply the call to __validindex that fails:

CodeInfo(
    @ /home/tim/Julia/pkg/KernelAbstractions/src/macros.jl:80 within `gpu_index_linear_global'
1 ─     (KernelAbstractions.__validindex)(__ctx__)::Union{}
└──     unreachable

@vchuravy Any thoughts?

EDIT: Oh, I wonder if this is an issue with the world age overlay table.

@vchuravy
Copy link
Member Author

vchuravy commented Apr 5, 2023

@maleadt
Copy link
Member

maleadt commented Apr 5, 2023

That's unexpected. But I don't feel like debugging this, so 🤷

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 64.13% and project coverage change: -0.86 ⚠️

Comparison is base (e821aa4) 86.30% compared to head (1b3a2b3) 85.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
- Coverage   86.30%   85.44%   -0.86%     
==========================================
  Files          39       40       +1     
  Lines        1825     1917      +92     
==========================================
+ Hits         1575     1638      +63     
- Misses        250      279      +29     
Impacted Files Coverage Δ
src/oneAPI.jl 80.00% <ø> (ø)
src/oneAPIKernels.jl 64.13% <64.13%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt maleadt merged commit 1932e2f into master Apr 5, 2023
@maleadt maleadt deleted the vc/ka branch April 5, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants