Choose parallel tests based on CPUs, not threads.

JuliaGPU · Mar 29, 2023 · 3bd8287 · 3bd8287
1 parent 6b05f9a
commit 3bd8287
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/src/device/opencl/memory.jl b/src/device/opencl/memory.jl
@@ -39,7 +39,7 @@ end
         alignment!(gv, Base.datatype_alignment(T))
 
         # generate IR
-        Builder(ctx) do builder
+        IRBuilder(ctx) do builder
             entry = BasicBlock(llvm_f, "entry"; ctx)
             position!(builder, entry)
 

diff --git a/src/device/opencl/printf.jl b/src/device/opencl/printf.jl
@@ -39,7 +39,7 @@ end
         mod = LLVM.parent(llvm_f)
 
         # generate IR
-        Builder(ctx) do builder
+        IRBuilder(ctx) do builder
             entry = BasicBlock(llvm_f, "entry"; ctx)
             position!(builder, entry)
 
@@ -49,7 +49,7 @@ end
             printf_typ = LLVM.FunctionType(T_int32, [T_pint8]; vararg=true)
             printf = LLVM.Function(mod, "printf", printf_typ)
             push!(function_attributes(printf), EnumAttribute("nobuiltin"; ctx))
-            chars = call!(builder, printf, [str, parameters(llvm_f)...])
+            chars = call!(builder, printf_typ, printf, [str, parameters(llvm_f)...])
 
             ret!(builder, chars)
         end

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -42,19 +42,21 @@ if do_help
                --help             Show this text.
                --list             List all available tests.
                --quickfail        Fail the entire run as soon as a single test errored.
-               --jobs=N           Launch `N` processes to perform tests (default: Threads.nthreads()).
+               --jobs=N           Launch `N` processes to perform tests (default: Sys.CPU_THREADS).
 
                Remaining arguments filter the tests that will be executed.""")
     exit(0)
 end
-_, jobs = extract_flag!(ARGS, "--jobs", Threads.nthreads())
+_, jobs = extract_flag!(ARGS, "--jobs", Sys.CPU_THREADS)
 do_quickfail, _ = extract_flag!(ARGS, "--quickfail")
 
 include("setup.jl")     # make sure everything is precompiled
 @info "System information:\n" * sprint(io->oneAPI.versioninfo(io))
 
 @info "Using oneAPI support library at " * oneAPI.Support.liboneapi_support
 
+@info "Running $jobs tests in parallel. If this is too many, specify the `--jobs` argument to the tests, or set the JULIA_CPU_THREADS environment variable."
+
 # choose tests
 const tests = []
 const test_runners = Dict()