Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use XUnit.jl for parallel testing. #121

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Use XUnit.jl for parallel testing. #121

merged 2 commits into from
Jun 30, 2023

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jun 29, 2023

Another attempt... I'm not sure why I reverted the previous one, presumably because it was using multiple threads, which doesn't really accelerate the test suite because we're doing lots of compilation here (which is still single-threaded)?

In any case, with the distributed test runner I can run the entire GemmKernels.jl test suite in 3 minutes or so.

@maleadt
Copy link
Member Author

maleadt commented Jun 29, 2023

Benchmark results for commit ce174c6 (comparing to 43deaf5):
No regressions or improvements detected.

@maleadt maleadt force-pushed the tb/xunit branch 2 times, most recently from 61efb4f to e1f8376 Compare June 29, 2023 20:36
@maleadt
Copy link
Member Author

maleadt commented Jun 30, 2023

CI failure is RelationalAI-oss/XUnit.jl#19. Let's wait until RelationalAI-oss/XUnit.jl#21 is merged and tagged.

@maleadt maleadt marked this pull request as ready for review June 30, 2023 10:52
@maleadt
Copy link
Member Author

maleadt commented Jun 30, 2023

I'm impatient, let's go with the hack for now.

@maleadt maleadt merged commit ef5e19b into master Jun 30, 2023
@maleadt maleadt deleted the tb/xunit branch June 30, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant