Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for external GPUCompiler uses to opt-out of disk cache #592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vchuravy
Copy link
Member

Doing it on the compiler params seems a bit odd, but for Enzyme the target is variable and
the params is special.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 36.66%. Comparing base (4178477) to head (e110b67).

Files Patch % Lines
src/execution.jl 0.00% 2 Missing ⚠️
src/interface.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #592       +/-   ##
===========================================
- Coverage   75.12%   36.66%   -38.47%     
===========================================
  Files          24       24               
  Lines        3482     3434       -48     
===========================================
- Hits         2616     1259     -1357     
- Misses        866     2175     +1309     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vchuravy vchuravy requested a review from maleadt June 28, 2024 18:19
@maleadt
Copy link
Member

maleadt commented Jul 4, 2024

The whole idea of the params is that they are opaque and not used in GPUCompiler itself. I don't think we should change that. Why can't this be a part of the CompilerConfig?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants