Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define compile_cache outside __init__() #471

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Conversation

simonbyrne
Copy link
Contributor

Potential fix to #470.

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.48 🎉

Comparison is base (d84aea2) 74.56% compared to head (4bbbee5) 75.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #471      +/-   ##
==========================================
+ Coverage   74.56%   75.04%   +0.48%     
==========================================
  Files          23       23              
  Lines        3070     3050      -20     
==========================================
  Hits         2289     2289              
+ Misses        781      761      -20     
Impacted Files Coverage Δ
src/GPUCompiler.jl 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maleadt
Copy link
Member

maleadt commented Jun 16, 2023

Did you verify this works?

@simonbyrne
Copy link
Contributor Author

Yes, it does seem to fix that error.

@maleadt maleadt merged commit 6bfe331 into JuliaGPU:master Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants