Add llvm_gnu_pubnames to Interface and set llvm_debug_info for native target #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
commented
May 22, 2023
| @@ -37,3 +37,13 @@ end | |||
|
|
|||
| runtime_slug(job::CompilerJob{NativeCompilerTarget}) = "native_$(job.config.target.cpu)-$(hash(job.config.target.features))$(job.config.target.jlruntime ? "-jlrt" : "")" | |||
| uses_julia_runtime(job::CompilerJob{NativeCompilerTarget}) = job.config.target.jlruntime | |||
|
|
|||
| function llvm_debug_info(@nospecialize(job::CompilerJob{NativeCompilerTarget})) | |||
There was a problem hiding this comment.
@gbaraldi I was debating to use simply FULL or Base.default_debug_info_kind() for all Native targets,
but maybe best not to change this for StaticCompiler.jl?
There was a problem hiding this comment.
StaticCompiler actually defines it's own target so I don't see an issue.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #456 +/- ##
==========================================
- Coverage 82.58% 81.40% -1.18%
==========================================
Files 23 23
Lines 3124 3125 +1
==========================================
- Hits 2580 2544 -36
- Misses 544 581 +37
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.