Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use safepoint_on_entry cgparam on 1.9-beta1 and up. #381

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Dec 28, 2022

This was reverted in JuliaLang/julia#47602, but is still live on master. cc @vchuravy

@maleadt
Copy link
Member Author

maleadt commented Dec 28, 2022

On the asserts build (FORCE_ASSERTIONS=1 LLVM_ASSERTIONS=1 JULIA_PRECOMPILE=0):

julia: /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/src/coverage.cpp:50: void jl_coverage_alloc_line(llvm::StringRef, int): Assertion `!codegen_imaging_mode()' failed.

[12378] signal (6.-6): Aborted
in expression starting at none:0
pthread_kill at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
raise at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
abort at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
unknown function (ip: 0x7feced49971a)
__assert_fail at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
jl_coverage_alloc_line at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/src/coverage.cpp:50
emit_function at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/src/codegen.cpp:7593
jl_emit_code at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/src/codegen.cpp:8171
jl_emit_codeinst at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/src/codegen.cpp:8219
_jl_compile_codeinst at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/src/jitlayers.cpp:203
jl_generate_fptr_impl at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/src/jitlayers.cpp:444
jl_compile_method_internal at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/src/gf.c:2244 [inlined]
jl_compile_method_internal at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/src/gf.c:2162
_jl_invoke at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/src/gf.c:2639 [inlined]
ijl_apply_generic at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/src/gf.c:2829
__init__ at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/usr/share/julia/stdlib/v1.10/LinearAlgebra/src/LinearAlgebra.jl:633
jfptr___init___35937 at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/usr/lib/julia/sys.so (unknown line)
_jl_invoke at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/src/gf.c:2628 [inlined]
ijl_apply_generic at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/src/gf.c:2829
jl_apply at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/src/julia.h:1869 [inlined]
jl_module_run_initializer at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/src/toplevel.c:75
_finish_julia_init at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/src/init.c:850
jl_repl_entrypoint at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/src/jlapi.c:711
main at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/cli/loader_exe.c:58
unknown function (ip: 0x7feced49ad8f)
__libc_start_main at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
_start at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/julia/usr/bin/julia (unknown line)
Allocations: 3004 (Pool: 2993; Big: 11); GC: 0
ERROR: LoadError: Failed to precompile GPUCompiler [61eb1bfa-7361-4325-ad38-22787b887f55] to "/home/runner/.julia/compiled/v1.10/GPUCompiler/jl_XP1NNe".
Stacktrace:
  [1] error(s::String)
    @ Base ./error.jl:35
  [2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::IO, internal_stdout::IO, keep_loaded_modules::Bool)
    @ Base ./loading.jl:2124
  [3] compilecache
    @ ./loading.jl:2016 [inlined]
  [4] _require(pkg::Base.PkgId, env::String)
    @ Base ./loading.jl:1660
  [5] _require_prelocked(uuidkey::Base.PkgId, env::String)
    @ Base ./loading.jl:1515
  [6] macro expansion
    @ ./loading.jl:1503 [inlined]
  [7] macro expansion
    @ ./lock.jl:267 [inlined]
  [8] require(into::Module, mod::Symbol)
    @ Base ./loading.jl:1466
  [9] include(fname::String)
    @ Base.MainInclude ./client.jl:478
 [10] top-level scope
    @ none:6
in expression starting at /home/runner/work/GPUCompiler.jl/GPUCompiler.jl/test/runtests.jl:7
ERROR: LoadError: Package GPUCompiler errored during testing

I'd guess this is related to JuliaLang/julia#47184 (not only because that changed precompilation, but also changed the very assertion condition that's triggered here). @vchuravy, any thoughts?

@maleadt
Copy link
Member Author

maleadt commented Dec 28, 2022

Same failure on master, so this PR isn't the culprit.

@maleadt maleadt merged commit d1a400a into master Dec 28, 2022
@maleadt maleadt deleted the tb/safepoint branch December 28, 2022 14:09
@vchuravy
Copy link
Member

Can you open an issue on Julia master w.r.t assert build?

@maleadt
Copy link
Member Author

maleadt commented Dec 29, 2022

Yeah sure: JuliaLang/julia#48035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants