This repository has been archived by the owner on Mar 12, 2021. It is now read-only.
Fix SplittingPool reclaim. #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should repopulate the pools from recently-freed blocks first.
vchuravy
reviewed
Jan 7, 2020
| @@ -422,12 +422,19 @@ function free(ptr) | |||
| end | |||
|
|
|||
| function reclaim(sz::Int=typemax(Int)) | |||
| freed = 0 | |||
| if !isempty(freed) | |||
| blocks = Set(freed) | |||
There was a problem hiding this comment.
Is this because the same block might be twice in the freed list? Or did you just want a lightweight copy?
There was a problem hiding this comment.
freed might be modified concurrently (from a finalizer), so I just want a copy re.
CuArrays.jl/src/memory/split.jl
Lines 336 to 342 in 0e7f8a9
I guess I decided back then to use a
Set because incremental_compact! pops values, but that might have been a relic of past developments (I should probably go through the different uses of containers now that the code has stabilized a bit).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should repopulate the pools from recently-freed blocks first.
As observed in #555.