This repository has been archived by the owner on Mar 12, 2021. It is now read-only.
Warn about missing libraries. #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Or maybe the warning should only trigger when importing the submodule? |
|
The one annoying one might be CUDNN, where the warning might be annoying for people who don't need it. But I'm not sure where else we'd put that. (Maybe the first time you do a GPU convolution or something?) Not a blocker in any case. |
No, this is only for CUDNN (and soon CUTENSOR); i.e. the ones that are optional. I'll have a look at trying to put it in the module import. |
maleadt
force-pushed
the
tb/warn_missing
branch
from
2fd38be
to
77c3cce
Compare
maleadt
force-pushed
the
tb/warn_missing
branch
from
77c3cce
to
fa5e0a5
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A warning seems annoying, but I don't think we can leave this one out (cc @MikeInnes, you've been vocal about such warnings).