This repository has been archived by the owner on Mar 12, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Massively speeds up host operations, without losing
assertscalar
-like functionality.Doesn't properly works right now, due to the coherency requirements of unified memory on pre-sm_60 hardware. Basically, we'd need to synchronize the device before doing any load from unified memory to make sure there's no kernel running (which claims ownership of the unified memory). That would wreck performance again.
I had hoped that JuliaGPU/CUDAdrv.jl#141 would fix this, but that only works around the issue when doing explicit copies (doing a
cudaMemcpy
instead of just loading from the memory). When indexing, we of course still do a regular memory load, running into the above issue.If and when we solve this problem, host/unified<->unified transfers should probably do a regular
memcpy
again (ie. what JuliaGPU/CUDAdrv.jl#141 reverted, but for good reasons).