General purpose broadcast for sparse CSR matrices. #1380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts the implementation from last week, adding general purpose broadcast support (i.e. involving multiple sparse inputs, dense arrays, scalars, etc). The trick here is to have a separate kernel count the nnz values per row so that we can allocate an output container that will fit all values, and use those values as row offsets (after scanning them). The only disadvantage of that approach is that it's synchronizing, to access the total nnz count, but performance seems pretty good nonetheless:
Still a WIP, I want to at least add CSC support.
cc @kshyatt @Roger-luo