Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROCmDiscovery: Ensure all globals are defined #679

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpsamaroo
Copy link
Member

This fixes a load-time error I get due to not having ROCm libraries available:

ERROR: InitError: UndefVarError: `libdevice_libs` not defined in `AMDGPU`
Suggestion: this global was defined as `AMDGPU.ROCmDiscovery.libdevice_libs` but not assigned a value.
Stacktrace:
  [1] functional(component::Symbol)
    @ AMDGPU ~/.julia/packages/AMDGPU/jLWP2/src/utils.jl:80
  [2] __init__()
    @ AMDGPU ~/.julia/packages/AMDGPU/jLWP2/src/AMDGPU.jl:210
...

Specifically, this doesn't remove the @error message that I get before this, but it just makes sure that using AMDGPU will still work without error even if the ROCm libraries aren't available.

@jpsamaroo jpsamaroo added bug Something isn't working deps labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant