-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update due to changes in GNSSSignals #40
Conversation
…nto ss/use-get_codes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@@ -11,6 +11,7 @@ struct TrackingResults{ | |||
} | |||
state::TS | |||
correlator::C | |||
filtered_prompt::ComplexF64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a special reason for putting the filtered prompt signal in the tracking results? In my opinion, this is quite unsafe to evaluate, as the tracking loop might generate more than one prompt (or even no).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's like correlator
, but filtered. correlator
holds the last valid correlation results (after a complete code length has been integrated). The same applies to filtered prompt. filtered_prompt
is needed because in some circumstances the filter can not be reconstructed outside of track. The implementation here allows to update the states of the post correlation filter every time there are new correlation results. Therefore, the state of the post correlation filter might be different at the time that track
returns.
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 79.52% 84.17% +4.65%
==========================================
Files 17 17
Lines 503 512 +9
==========================================
+ Hits 400 431 +31
+ Misses 103 81 -22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Bump GNSSSignals to v0.16 and remove BOC specialized code.