Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export fill_surrogate_test! #161

Merged
merged 9 commits into from
Jun 4, 2024
Merged

Export fill_surrogate_test! #161

merged 9 commits into from
Jun 4, 2024

Conversation

Datseris
Copy link
Member

I hope the title is self-explanatory!

I hope the title is self-explanatory!
@Datseris
Copy link
Member Author

what the hell is this test failure that I can barely understand :D

@Datseris
Copy link
Member Author

turns out, you cannot put docstrings before @inbounds.

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.62%. Comparing base (2f0077f) to head (8ca955e).
Report is 1 commits behind head on main.

Current head 8ca955e differs from pull request most recent head a11615c

Please upload reports for the commit a11615c to get more accurate results.

Files Patch % Lines
src/core/surrogate_test.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
+ Coverage   88.23%   90.62%   +2.38%     
==========================================
  Files          24       22       -2     
  Lines         986      960      -26     
==========================================
  Hits          870      870              
+ Misses        116       90      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kahaaga
Copy link
Member

kahaaga commented Jan 17, 2024

turns out, you cannot put docstrings before @inbounds.

Nice to know :D

@kahaaga
Copy link
Member

kahaaga commented Jan 17, 2024

There's a weird test error. Not sure why this occurs. Do the docs build locally?

@kahaaga
Copy link
Member

kahaaga commented Jan 20, 2024

The doc errors are not as cryptic, but there's still a few points to fix:

Skjermbilde 2024-01-20 kl  17 23 22

@kahaaga
Copy link
Member

kahaaga commented Jun 4, 2024

Screenshot 2024-06-04 at 12 52 06

Is it on purpose that this figure isn't displayed in the generated docs, @Datseris ?

@Datseris Datseris merged commit e5c5cd0 into main Jun 4, 2024
3 checks passed
@Datseris Datseris deleted the correct_test branch June 4, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants