Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #399 #423

Closed
wants to merge 2 commits into from
Closed

Issue #399 #423

wants to merge 2 commits into from

Conversation

franzi448
Copy link
Contributor

Added conditional loading for extensions for 'collect_results'.

@Datseris
Copy link
Member

Thanks for the effort @franzi448 , but I think if we do this we should formally move to 1.9 Julia version and remove Requires completely from the source code. Given that 1.10 becomes the new LTS version, I am feeing comfortable to increment the Julia version in Project.toml.

@franzi448
Copy link
Contributor Author

Alright, so should I remove the 'Requires' pkg from the project.toml and main code or should I not proceed with the PR?

@Datseris
Copy link
Member

Sorry, I wasn't clear: remove Requires from the source code, and bump Julia version to 1.9!

@franzi448 franzi448 closed this Aug 26, 2024
@franzi448 franzi448 deleted the Issue_#399 branch August 26, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants