Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract function to create custom gitignore file #404

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

fabiofortkamp
Copy link
Contributor

This attemps to solve #403 by including a keyword argument to the initialize_project function to customize the folders to be included in the .gitignore file. Default options is to preserve the current gitignore file.

@Datseris
Copy link
Member

Datseris commented Feb 7, 2024

Thanks, this is an example of a perfect pr: has tests, docs, and increments project version. will merge once tests pass!

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cad2a38) 90.65% compared to head (962c02f) 90.47%.

Files Patch % Lines
src/project_setup.jl 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
- Coverage   90.65%   90.47%   -0.19%     
==========================================
  Files           8        8              
  Lines         760      787      +27     
==========================================
+ Hits          689      712      +23     
- Misses         71       75       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Datseris Datseris merged commit 59118d2 into JuliaDynamics:main Feb 7, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants