-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix non-text/plain output for Markdown and LaTeX #938
Conversation
Hmm, the images on the
I suggest we put this in as an enhancement in 0.22 even though it might technically be eligible for a backport? |
Definitely. |
Yea I guess, I just didn't enable gif output for markdown files, but should be the same as e.g. png's I guess. It took the text/plain path here (which is still better than the current status which errors since the markdown writer can not handle |
A few more thoughts:
To test the MkDocs build, |
465ca41
to
6ce3420
Compare
5eda383
to
c80099f
Compare
and LaTeX output by capturing several output representations and let each writer choose which one to render, fixes #916, fixes fredrikekre/Literate.jl#49. Co-authored-by: Morten Piibeleht <morten.piibeleht@gmail.com> Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
c80099f
to
fa99699
Compare
\\includegraphics{$(filename)} | ||
\\end{figure} | ||
""") | ||
elseif haskey(d, MIME"text/latex"()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't it make sense to prefer text/latex
in latex writer? I don't use latex writer myself so I don't know what's the optimal order, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it made sense to prioritize more rich formats, such as images, before latex 🤷♂️. I don't think it is very commong for things to be showable
in both formats so probably doesn't matter.
Fix non-text/plain output for Markdown
and LaTeX output by capturing several
output representations and let each writer
choose which one to render,
fixes #916, fixes fredrikekre/Literate.jl#49.