Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle DOCUMENTER_KEY errors better in deploydocs #907

Merged
merged 3 commits into from
Dec 10, 2018
Merged

Handle DOCUMENTER_KEY errors better in deploydocs #907

merged 3 commits into from
Dec 10, 2018

Conversation

mortenpi
Copy link
Member

@mortenpi mortenpi commented Dec 10, 2018 •
edited
Loading

Print a more helpful error if base64decode fails for the provided key, or git fetch throws an error, most likely due to a key misconfiguration. Also, use SSH batch mode, which means that SSH won't ask for passphrase and time out the Travis build if the SSH key is problematic.

Closes #697

@mortenpi mortenpi added this to the 0.21.0 milestone Dec 10, 2018
@mortenpi
Handle DOCUMENTER_KEY errors better in deploydocs
b85f32c 
* Print a more helpful error if base64decode fails for the provided key.
* Use SSH batch mode -- this means that SSH won't ask for passphrase
  and time out the Travis build if the SSH key is problematic.
* Also, print a more helpful error if git fetch throws an error, most
  likely due to a key misconfiguration.

Closes #697
@mortenpi mortenpi merged commit 63bb9ef into master Dec 10, 2018
@mortenpi mortenpi deleted the mp/fix-697 branch December 10, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre approved these changes

Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mortenpi @fredrikekre