-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker for latex #891
docker for latex #891
Conversation
180e10a
to
1dba321
Compare
Seems to be some file permission mismatch in the docker container: |
e916687
to
b6e5d3e
Compare
Ok. This works now. |
I tried running the latexmk backend locally with
The PDF looks fine though. I am also not seeing any Also, interestingly, it seems that
I'll try to debug further tomorrow. |
Maybe you had some old files around that got copied? This PR does not touch the dispatching code at all so... Edit: The pdf must also have been old, because the |
Right, my bad. My
And from
I've put the full output here: https://gist.github.com/mortenpi/d103b0e4bbb19b6ef5a1e842e81e0b71 |
Ah, it looks like if we have an empty index block (which happened right now, since for some reason Documenter can't find docstrings when running the
This (possibly stupid) patch fixes the problem: diff --git a/src/Writers/LaTeXWriter.jl b/src/Writers/LaTeXWriter.jl
index 8253dc2c..5ef16de1 100644
--- a/src/Writers/LaTeXWriter.jl
+++ b/src/Writers/LaTeXWriter.jl
@@ -250,6 +250,7 @@ end
## Index, Contents, and Eval Nodes.
function latex(io::IO, index::Documents.IndexNode, page, doc)
+ length(index.elements) > 0 || return
_println(io, "\\begin{itemize}")
for (object, _, page, mod, cat) in index.elements
id = string(hash(string(Utilities.slugify(object))))
@@ -263,6 +264,7 @@ function latex(io::IO, index::Documents.IndexNode, page, doc)
end
function latex(io::IO, contents::Documents.ContentsNode, page, doc)
+ length(contents.elements) > 0 || return
depth = 1
needs_end = false
_println(io, "\\begin{itemize}") |
6ad6ee6
to
2089c4b
Compare
2089c4b
to
d8986dd
Compare
cc3ca96
to
cd1bea4
Compare
I'm thinking that I update the CHANGELOG and then this is good to go from my side |
ff3b35b
to
395df27
Compare
I'd like to merge this to try it out and then fix any remainiing things in follow up PRs before the 0.21 release. |
I'll have a look at coverage later. |
No description provided.