Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove julia and osname kwarg from deploydocs #816

Merged
merged 1 commit into from
Sep 3, 2018
Merged

Conversation

fredrikekre
Copy link
Member

Remove julia and osname kwarg from deploydocs and recommend using Travis Build Stages instead.

@fredrikekre
Copy link
Member Author

Actually made this non-breaking (I think?).

@fredrikekre fredrikekre force-pushed the fe/build-stage branch 2 times, most recently from 71387e7 to 722c095 Compare August 30, 2018 22:52
src/Documenter.jl Outdated Show resolved Hide resolved
@fredrikekre
Copy link
Member Author

Bump for review.

Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not reviewing this earlier. Two small questions, but overall looks great!

- julia -e 'cd(Pkg.dir("PACKAGE_NAME")); include(joinpath("docs", "make.jl"))'
jobs:
include:
- stage: "Deploy docs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe have the suggested name for the build stage here be "Documentation". "Deploy docs" has always bothered me a tiny bit.

travis_osname = get(ENV, "TRAVIS_OS_NAME","")
if !(julia == travis_julia && osname == travis_osname)
@info("skipping docs deployment.")
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe go all-in and not deploy at all if julia and/or osname is defined? Since julia is mandatory at the moment, it should catch everyone who go to 0.20.0 without updating make.jl (may take a while before people notice though). So this should make sure that people don't get weird deployments when they accidentally start using 0.20.

docs/src/man/hosting.md Outdated Show resolved Hide resolved
and recommend using Travis Build Stages instead.
@fredrikekre fredrikekre merged commit d5eabaa into master Sep 3, 2018
@fredrikekre fredrikekre deleted the fe/build-stage branch September 3, 2018 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants