Remove julia and osname kwarg from deploydocs #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
force-pushed
the
fe/build-stage
branch
from
b2c7ba5
to
a3af582
Compare
|
Actually made this non-breaking (I think?). |
fredrikekre
force-pushed
the
fe/build-stage
branch
2 times, most recently
from
71387e7
to
722c095
Compare
fredrikekre
commented
Sep 1, 2018
fredrikekre
force-pushed
the
fe/build-stage
branch
from
722c095
to
accb234
Compare
|
Bump for review. |
mortenpi
reviewed
Sep 2, 2018
docs/src/man/hosting.md
Outdated
| - julia -e 'cd(Pkg.dir("PACKAGE_NAME")); include(joinpath("docs", "make.jl"))' | ||
| jobs: | ||
| include: | ||
| - stage: "Deploy docs" |
There was a problem hiding this comment.
Maybe have the suggested name for the build stage here be "Documentation". "Deploy docs" has always bothered me a tiny bit.
src/Documenter.jl
Outdated
| travis_osname = get(ENV, "TRAVIS_OS_NAME","") | ||
| if !(julia == travis_julia && osname == travis_osname) | ||
| @info("skipping docs deployment.") | ||
| end |
There was a problem hiding this comment.
Should we maybe go all-in and not deploy at all if julia and/or osname is defined? Since julia is mandatory at the moment, it should catch everyone who go to 0.20.0 without updating make.jl (may take a while before people notice though). So this should make sure that people don't get weird deployments when they accidentally start using 0.20.
fredrikekre
force-pushed
the
fe/build-stage
branch
from
accb234
to
560de7d
Compare
mortenpi
reviewed
Sep 2, 2018
and recommend using Travis Build Stages instead.
fredrikekre
force-pushed
the
fe/build-stage
branch
from
560de7d
to
2f9f705
Compare
mortenpi
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove julia and osname kwarg from deploydocs and recommend using Travis Build Stages instead.