Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define include in sandbox-modules #794

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Define include in sandbox-modules #794

merged 1 commit into from
Aug 15, 2018

Conversation

fredrikekre
Copy link
Member

@fredrikekre fredrikekre commented Aug 14, 2018 •
edited by mortenpi
Loading

Fix #793

@fredrikekre fredrikekre added this to the 0.20.0 milestone Aug 14, 2018
@mortenpi
Copy link
Member

Hmm, so at-repl/at-example block were missing eval(). LGTM, although it might be good to throw a few examples into test/examples showing that this works.

@fredrikekre fredrikekre merged commit 1bc1d77 into master Aug 15, 2018
@fredrikekre fredrikekre deleted the fe/include branch August 15, 2018 15:12
@fredrikekre fredrikekre mentioned this pull request Aug 31, 2018
Closed
@mortenpi mortenpi changed the title Define include in sandbox-modules, fix #793. Define include in sandbox-modules Sep 17, 2018
mortenpi added a commit that referenced this pull request Oct 9, 2019
@mortenpi
Use proper sandbox for at-setup blocks too
11b0994 
Apply the fix from #794 to also SetupBlocks. Fix #1148.
@mortenpi mortenpi mentioned this pull request Oct 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenpi mortenpi Awaiting requested review from mortenpi

Assignees
No one assigned
Labels
Type: Bug Type: Enhancement
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @mortenpi