Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Travis.genkeys and Documenter.generate #789

Merged
merged 5 commits into from
Aug 16, 2018
Merged

Remove Travis.genkeys and Documenter.generate #789

merged 5 commits into from
Aug 16, 2018

Conversation

fredrikekre
Copy link
Member

@mortenpi mortenpi added this to the 0.20.0 milestone Aug 10, 2018
mortenpi
mortenpi reviewed Aug 10, 2018
View reviewed changes
docs/src/man/hosting.md Outdated
about Travis environment variables in [Travis User Documentation](https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings).
!!! warning
Read the `DocumenterTools` documentation carefully. SSH keys give push access
to the repository, and should be handled with care.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather keep the tutorial here and have DocumenterTools refer to this repo. This way the user is not forced to jump between the docs of different packages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, seems like a good idea.

@fredrikekre
Copy link
Member Author

This now includes the docs from DocumenterTools here.

@fredrikekre fredrikekre changed the title WIP remove Travis.genkeys and Documenter.generate Remove Travis.genkeys and Documenter.generate Aug 15, 2018
@fredrikekre
Copy link
Member Author

I'll merge this now to avoid further conflicts and we can improve it if needed during the 0.20-dev cycle.

@fredrikekre fredrikekre merged commit 7878718 into master Aug 16, 2018
@fredrikekre fredrikekre deleted the fe/doctools branch August 16, 2018 05:56
@mortenpi
Copy link
Member

Documenter's own docs were built as part of the tests so that the CI would fail in case Documenter's own manual doesn't build (or deploy). But we might be able to put it into a build stage..

Once DocumenterTools gets tagged, docs/Manifest.toml goes away, right?

@fredrikekre
Copy link
Member Author

Documenter's own docs were built as part of the tests so that the CI would fail in case Documenter's own manual doesn't build (or deploy).

Yea I know, but we can't load DocumenterTools from testing, unless adding it as a test dependency, which we can't do since it is not registered yet. (Well, we could add it in the test script but ...).

Once DocumenterTools gets tagged, docs/Manifest.toml goes away, right?

Yea, just need it to find the url for now.

We should definitely fix this before the next Documenter release, just wanted to get this in for now.

fredrikekre added a commit that referenced this pull request Aug 23, 2018
@fredrikekre
Remove src/Generator.jl, unused since #789.
ad82655
fredrikekre added a commit that referenced this pull request Aug 24, 2018
@fredrikekre
Silence some warning from Documenter tests. (#815)
41e8663 
* Silence some warning from Documenter tests.

* Remove src/Generator.jl, unused since #789.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenpi mortenpi mortenpi left review comments

Assignees
No one assigned
Labels
Type: Breaking Type: Decision Type: Feature
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikekre @mortenpi