Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "auto" theme option to theme picker dropdown #2085

Closed
wants to merge 5 commits into from
Closed

Add "auto" theme option to theme picker dropdown #2085

wants to merge 5 commits into from

Conversation

shravanngoswamii
Copy link
Contributor

"auto" theme is added in theme picker, is it ok?
#2077 (comment)

@shravanngoswamii
Updated theme picker setup!!
ab49d82 
"auto" theme is added in theme picker, is it ok?
JuliaDocs#2077 (comment)
@shravanngoswamii shravanngoswamii mentioned this pull request Mar 23, 2023
Closed
@mortenpi
Copy link
Member

Yeah, this looks like what I had in mind. But it also needs to have the corresponding entry in the dropdown for this to work.

Also, please don't open separate PRs, but iterate on the code in the existing PR.

@mortenpi mortenpi linked an issue Mar 24, 2023 that may be closed by this pull request
Reenable auto-switching between light and dark theme #1745
Closed
@shravanngoswamii
updated previous commit
b19734f 
Add "auto" option to the dropdown
@shravanngoswamii
Copy link
Contributor Author

Entry in dropdown is added, will it work now!!

@shravanngoswamii shravanngoswamii deleted the patch-1 branch March 24, 2023 13:39
@shravanngoswamii shravanngoswamii restored the patch-1 branch March 24, 2023 13:54
@shravanngoswamii
Copy link
Contributor Author

I am really sorry for inconvenience, I closed this PR by mistake!!

mortenpi
mortenpi reviewed Mar 27, 2023
View reviewed changes
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more things:

  • It should also update the theme if you change to auto. I.e. basically needs a call to set_theme, but might need to be updated a bit to handle this case.
  • It would be great to have a small note in CHANGELOG.md about this as well.

assets/html/js/themes.js Outdated Show resolved Hide resolved
@mortenpi mortenpi changed the title Updated theme picker setup!! Add "auto" theme option to theme picker dropdown Mar 27, 2023
@mortenpi
Copy link
Member

The switching back to OS theme doesn't seem to work. Does it work for you when you run it locally?

@shravanngoswamii
Copy link
Contributor Author

Actually, I am having an error while running Documenter.jl locally, i update the code soon if OS theme doesn't work!!

@mortenpi mortenpi mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenpi mortenpi mortenpi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reenable auto-switching between light and dark theme
2 participants
@shravanngoswamii @mortenpi