-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "auto" theme option to theme picker dropdown #2085
Conversation
"auto" theme is added in theme picker, is it ok? JuliaDocs#2077 (comment)
Yeah, this looks like what I had in mind. But it also needs to have the corresponding entry in the dropdown for this to work. Also, please don't open separate PRs, but iterate on the code in the existing PR. |
Add "auto" option to the dropdown
Entry in dropdown is added, will it work now!! |
I am really sorry for inconvenience, I closed this PR by mistake!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more things:
- It should also update the theme if you change to
auto
. I.e. basically needs a call toset_theme
, but might need to be updated a bit to handle this case. - It would be great to have a small note in
CHANGELOG.md
about this as well.
The switching back to OS theme doesn't seem to work. Does it work for you when you run it locally? |
Actually, I am having an error while running Documenter.jl locally, i update the code soon if OS theme doesn't work!! |
"auto" theme is added in theme picker, is it ok?
#2077 (comment)