-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom tag prefix for release docs #1993
Support custom tag prefix for release docs #1993
Conversation
wip - next step: update/redo current pr's approach to |
This is my first PR for this repo, so let me know if there are additional tests/docs/etc that I should include here! This implementation is non-breaking, so could potentially be included in (or back-ported to) a v0.27 patch. Since the changelog shows the next unreleased version as 0.28.0 (and I see that this issue has been added to the 0.28.0 milestone) I've only added it to the changelog's 0.28.0 section. Also, from #1792 I considered
I started with the basic prefix option, with the idea that once I got a hang for the structure of the codebase I'd know how complicated the regex option would be to plumb through. After adding the basic prefix option, though, I think that it is sufficient for the original motivating feature request that @ericphanson described (in regards to our particular monorepo). I also think the regex option could introduce complicated implementation around versioned tags that maybe isn't worth taking on until there's a motivating use case without a simpler solution. (I suspect that it would likely be relevant for a non-versioned tag workflow.) |
Closes #1291. |
I'm not sure why the changelog CI is failing---when I ran it locally yesterday it passed. Any hints on what might be failing there would be welcome! |
You just need to add the Markdown link definition to the PR at the bottom of the file. |
thanks! added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks excellent! I presume it's good to go?
Do you happen to have an example run somewhere with the branch?
Nothing public facing, so I started an example public monorepo (https://github.com/hannahilea/ExampleMonorepo.jl); I ran out of time to try it on this branch but should have the example running tomorrow. Will update when that's up! |
Here's an example monorepo that uses this Documenter.jl branch---note that each package (ExampleMonorepo.jl, SubpackageA.jl, and SubpackageB.jl) was each tagged with a separate version so that it's clear that each docs version is correct:
|
That looks awesome. Thanks a lot! |
Implement #1792. Is non-breaking.
version_tag_strip_build
deploy_folder
deploydocs
Edit by @mortenpi: close #1792, close #1291