Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Git JLL for git (via Git.jl; except on Macs) #1855

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

mortenpi
Copy link
Member

We still use the system git on Mac to work around the linking problems. Setting GIT_TEMPLATE_DIR (which Git.jl does) is necessary to make sure that our git init and git clone invocations do not pick up user-specific Git hooks etc (which can fail the tests).

@KristofferC
Copy link
Member

What's the size of this download?

@mortenpi
Copy link
Member Author

You mean the JLL artifacts? Is there a way to easily get that info? Git_jll appears the be on the order of 40-50MB (which is actually more than I thought it would be). But it also brings along a bunch of dependencies:

(gitjll) pkg> st -m
      Status `~/Julia/test/gitjll/Manifest.toml`
  [d7ba0133] Git v1.2.1
  [692b3bcd] JLLWrappers v1.4.1
  [21216c6a] Preferences v1.3.0
  [2e619515] Expat_jll v2.4.8+0
  [78b55507] Gettext_jll v0.21.0+0
  [f8c6e375] Git_jll v2.34.1+0
  [94ce4f54] Libiconv_jll v1.16.1+1
  [458c3c95] OpenSSL_jll v1.1.16+0
  [02c8fc9c] XML2_jll v2.9.14+0

Any particular circumstance where you'd be concerned about the size of the download?

@mortenpi mortenpi marked this pull request as draft July 4, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants