Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically determine edit_link default #1830

Merged
merged 20 commits into from
Jun 2, 2022
Merged

Automatically determine edit_link default #1830

merged 20 commits into from
Jun 2, 2022

Conversation

mortenpi
Copy link
Member

Generalizes the solution to devbranch to also apply to edit_link. Fix #1827.

It also now prints a warning (for both devbranch and edit_link) if the git remote solution somehow fails. I think this is a good idea, because otherwise you might get some weird intermittent environment-dependent failures which are hard to debug. The warning should at least give you a hint where things might be going wrong.

src/Utilities/Utilities.jl Outdated Show resolved Hide resolved
@mortenpi mortenpi added Type: Enhancement Format: HTML Related to the default HTML output labels May 27, 2022
@mortenpi mortenpi added this to the 0.27.19 milestone Jun 2, 2022
@mortenpi mortenpi merged commit fc80f3b into master Jun 2, 2022
@mortenpi mortenpi deleted the mp/fix-1827 branch June 2, 2022 07:37
@fredrikekre
Copy link
Member

I noticed in Literate that the call to git remote show here takes ~1s (fredrikekre/Literate.jl@8054d26). It is not a huge problem here since you only call makedocs once, but a bit annoying when using LiveServer for example. (It wasn't a problem before since it was only used in deploydocs which doesn't run in that case).

fredrikekre pushed a commit that referenced this pull request Jun 3, 2022
@mortenpi
Copy link
Member Author

mortenpi commented Jun 3, 2022

Should we also maybe do #1838 for this?

That said, something that I didn't think about before, I believe this could potentially block for up to 300s (TCP timeout) if you're having some weird networking problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default edit_link to default branch rather than "master"
2 participants