-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically determine edit_link default #1830
Conversation
I noticed in Literate that the call to |
(cherry picked from commit fc80f3b)
Should we also maybe do #1838 for this? That said, something that I didn't think about before, I believe this could potentially block for up to 300s (TCP timeout) if you're having some weird networking problems. |
(cherry picked from commit fc80f3b)
Generalizes the solution to
devbranch
to also apply toedit_link
. Fix #1827.It also now prints a warning (for both
devbranch
andedit_link
) if thegit remote
solution somehow fails. I think this is a good idea, because otherwise you might get some weird intermittent environment-dependent failures which are hard to debug. The warning should at least give you a hint where things might be going wrong.