Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TeX] Allow custom preamble #1788
[TeX] Allow custom preamble #1788
Changes from 19 commits
31be46a
a8fd795
9c78614
e3932d8
26b3f22
ea0f13c
6cbc706
9c6a063
7462011
7bf8de9
015a68a
adf8259
b2060aa
947997f
f204fa0
3a256de
430c06a
585c9c9
e0a2c6f
5ced822
c488b9f
465b3d5
777f41a
028d103
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we rarely use
TRAVIS
anymore, should we just set the\DocVersion
variable toVERSION
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis is definitely gone. @mortenpi ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized that
VERSION
refers to the version of julia, but for users of Documenter.jl, it's more like they want the version of their own package.Maybe this variable should be deprecated or deleted.
If the user needs the version number to be displayed, just append it to the site name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just thinking the same thing - I don't recollect what TRAVIS_TAG refers to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And
Documenter.jl/src/deployconfig.jl
Lines 136 to 139 in cd49b07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this would just try to determine the package version number automatically, but only works if it's being used on Travis (or if the user sets the environment variable themselves; e.g. it used to work for Documenter). However, I don't think it's actually good that it's quietly relying on the enviroment variable.
I would suggest adding another
version
variable to theLaTeX
object. To make this non-breaking and non-behavior-changing, it can still just default toget(ENV, "TRAVIS_TAG", "")
, but I think it should be documented that this default is deprecated. On the Julia side, we can then populate this new option so that the resulting PDFs would actually contain a version number.