Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thrown an error if the repo path contains the protocol #1533

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Thrown an error if the repo path contains the protocol #1533

merged 2 commits into from
Feb 23, 2021

Conversation

giordano
Copy link
Contributor

Fix #1531.

@fredrikekre
Copy link
Member

Huh, why did this try to deploy a preview?

@mortenpi
Copy link
Member

LGTM, thanks @giordano!

Huh, why did this try to deploy a preview?

I think because external PRs still define GITHUB_TOKEN. It's just that it doesn't have the right permissions. Hasn't shown up before because we switched to GHA only recently.

@mortenpi mortenpi added this to the 0.27.0 milestone Feb 20, 2021
@mortenpi mortenpi mentioned this pull request Feb 20, 2021
Closed
@mortenpi mortenpi merged commit 80a86d7 into JuliaDocs:master Feb 23, 2021
@giordano giordano deleted the mg/repo-no-protocol branch February 23, 2021 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

Throw an error if repo contains a protocol
3 participants
@giordano @fredrikekre @mortenpi