Remove unused fallback method for post_status #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In git_push we only use the method that passes the DeployConfig as the first positional argument, so this one is unnecessary. Potentially using this method in Documenter in the future is probably a bad idea, since it calls auto_detect_deploy_system() again, potentially introducing environment-dependent bugs.
|
I use it e.g. here: https://github.com/fredrikekre/Literate.jl/blob/master/docs/make.jl#L7 |
|
Arguably it would be better to change that to Documenter.post_status(Documenter.auto_detect_deploy_system(); type="pending", repo="github.com/fredrikekre/Literate.jl.git")? |
fredrikekre
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
git_pushwe only use the method that passes theDeployConfigas the first positional argument, so this one is unnecessary. Potentially using this method in Documenter in the future is probably a bad idea, since it callsauto_detect_deploy_system()again, potentially introducing environment-dependent bugs.