Add Gitlab deployconfig. #1448
Merged
Add Gitlab deployconfig. #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be great to have this. |
MichaelHatherly
commented
Oct 22, 2020
MichaelHatherly
force-pushed
the
mh/gitlab
branch
from
a8dc2e1
to
2bd7675
Compare
|
Linkcheck failure appears to be a gitlab URL. Gitlab is currently down as far as I can tell. |
mortenpi
reviewed
Oct 24, 2020
Merged
|
Comments addressed, should be good to go. |
fredrikekre
approved these changes
Oct 25, 2020
There was a problem hiding this comment.
Perhaps also modify https://github.com/JuliaDocs/Documenter.jl/pull/1448/files#diff-d03fe9850a3ee98315d4daf8671a29f0dc15348540762a9643d1cca14a5bc873R643 to autodetect GitLab?
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick exploratory PR to discuss whether we want to upstream this, since it makes running docs builds on gitlab CI and then uploading to gh pages easier. This is all the work of @jkrumbiegel, I'm just merely making the PR.
If we do what this then I'll add some tests and docs accordingly.