-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gitlab deployconfig. #1448
Add Gitlab deployconfig. #1448
Conversation
I think it would be great to have this. |
a8dc2e1
to
2bd7675
Compare
Linkcheck failure appears to be a gitlab URL. Gitlab is currently down as far as I can tell. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few cosmetic comments, otherwise LGTM!
Comments addressed, should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps also modify https://github.com/JuliaDocs/Documenter.jl/pull/1448/files#diff-d03fe9850a3ee98315d4daf8671a29f0dc15348540762a9643d1cca14a5bc873R643 to autodetect GitLab?
LGTM, thanks! |
Just a quick exploratory PR to discuss whether we want to upstream this, since it makes running docs builds on gitlab CI and then uploading to gh pages easier. This is all the work of @jkrumbiegel, I'm just merely making the PR.
If we do what this then I'll add some tests and docs accordingly.