-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying URLs for LaTeX engines #1430
Conversation
Thanks for the PR! I think it would be more natural to handle all of it in the
|
A new field For such a small enhancement, I was wondering if one maintainer/committer could make it happen soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty of modifying the tests a bit, to make sure we test all the cases. I would have two more requests before merging though:
- Also add the same argument for
KaTeX
(for consistency). - Update the docstrings to reflect this argument
I don't have much knowledge of
Would you confirm that this is also the case for other CDNs? I was thinking it be more efficient if I hand over this PR to you and you could do this in a single commit -- what'd you say? |
I'm afraid that might not really be the case -- it's much less time-consuming just to review, so it would probably be a while before I get around to this in that situation. Regarding KaTeX: you are right, I had forgotten that it was a bit more complicated. Let's leave KaTeX as it is. |
docstrings is updated. Many thanks for your help with the test cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ianqsong! I took the liberty of doing a few edits. Once the tests pass, this should be good to go.
Actually, the query parameters are perfectly fine. We even use them in the default MathJax v2 URL. The confusion arose because the default URL https://cdn.jsdelivr.net/npm/mathjax@2/MathJax.js?config=TeX-AMS-MML_CHTML is actually buggy -- there is no TeX-AMS-MML_CHTML, at least not in that CDN for the 2.7.9 version of MathJax.
@ianqsong was the closing of the PR accidental? |
sorry, a fat-finger mistake |
add a field for MathJax CDN that user can input by calling Documenter.HTML
Edit by @mortenpi: fix #1428