Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the nightly tests #1398

Merged
merged 6 commits into from
Aug 13, 2020
Merged

Fix the nightly tests #1398

merged 6 commits into from
Aug 13, 2020

Conversation

mortenpi
Copy link
Member

Nightly tests for docstring fixing are failing because of the Array{1/2} -> Vector/Matrix printing change in 1.6. This works around the version-dependence by reshaping the arrays into a higher-dimensional array, which still prints the same way.

It seems that on 1.6, the filename and line number are on a separate
line, with an @ in the beginning. The updated regex should handle both
the old and new stacktraces.
This removes the deprecation warnings from test logs.
This removes them from the output.
@mortenpi
Copy link
Member Author

The HTMLWriter Markdown node conversion tests still fail, but that appears to be due to JuliaDocs/DocStringExtensions.jl#93 and should be fixed by JuliaDocs/DocStringExtensions.jl#96.

@mortenpi mortenpi merged commit faace88 into master Aug 13, 2020
@mortenpi mortenpi deleted the mp/nightlytests branch August 13, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant