Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent HTML classs for stdout/err in example #1360

Merged
merged 7 commits into from
Jul 14, 2020

Conversation

tkf
Copy link
Contributor

@tkf tkf commented Jul 9, 2020

This is a follow up of #1357. While #1357 handled evaluated output, it didn't handle the HTML class of stdout/stderr. This PR fixes it.

@mortenpi mortenpi added this to the 0.25.1 milestone Jul 12, 2020
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again @tkf!

I added the example-output.md also into the LaTeX builds, to make sure that nothing broke there, as the change was (appropriately) in the general expanders, rather than in HTMLWriter.

@tkf
Copy link
Contributor Author

tkf commented Jul 12, 2020

Great! Thanks for the review and the clean-ups.

It looks like the CIs are happy with it now.

@mortenpi mortenpi merged commit 676a8f0 into JuliaDocs:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants